gitignore

.gitignore

@@ -3,3 +3,4 @@ todo-server-yaml
 cmd/cmd
 cmd/cli
 cmd/pttodo/pttodo
+cmd/pttodo-cli/pttodo-cli

cmd/pttodo-cli/cli.go

@@ -14,6 +14,7 @@ import (
 	"sort"
 	"strings"
 	"syscall"
+	"time"
 
 	"gopkg.in/yaml.v2"
 )
@@ -26,13 +27,15 @@ const (
 )
 
 type config struct {
-	targets []string
-	mergeme string
-	root    string
-	tags    []string
-	search  string
-	edit    bool
-	dry     bool
+	targets     []string
+	mergeme     string
+	root        string
+	tags        []string
+	search      string
+	edit        bool
+	dry         bool
+	add         string
+	addSchedule string
 }
 
 func main() {
@@ -48,6 +51,14 @@ func _main() error {
 			return err
 		}
 	}
+	if config.add != "" {
+		if err := add(config.dry, config.targets, pttodo.Todo{
+			Todo:     config.add,
+			Schedule: pttodo.Schedule(config.addSchedule),
+		}); err != nil {
+			return err
+		}
+	}
 	if config.edit {
 		if err := edit(config.dry, config.targets); err != nil {
 			return err
@@ -72,6 +83,8 @@ func getConfig() config {
 	flag.StringVar(&config.search, "search", "", "fts case insensitive")
 	flag.BoolVar(&config.edit, "e", false, "edit file")
 	flag.BoolVar(&config.dry, "dry", false, "dry run")
+	flag.StringVar(&config.add, "add", "", "todo to add")
+	flag.StringVar(&config.addSchedule, "add-schedule", "", "todo to add schedule")
 	flag.Parse()
 
 	config.tags = strings.Split(tagss, ",")
@@ -108,6 +121,34 @@ func verifyFile(path string) error {
 	return nil
 }
 
+func add(dry bool, filepaths []string, todo pttodo.Todo) error {
+	target := filepaths[0]
+	var original pttodo.Root
+
+	r, err := filePathReader(target)
+	if err != nil {
+		return err
+	}
+	if err := yaml.NewDecoder(r).Decode(&original); err != nil {
+		return err
+	}
+
+	original.Todo = append([]pttodo.Todo{todo}, original.Todo...)
+	original.AutoMove()
+
+	c, err := yaml.Marshal(original)
+	if err != nil {
+		return err
+	} else if dry {
+		log.Printf("wouldve written...\n%s", c)
+		return nil
+	} else if err := ioutil.WriteFile(target, c, os.ModePerm); err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func edit(dry bool, filepaths []string) error {
 	tempDir, err := ioutil.TempDir(os.TempDir(), "edit-pttodo-*")
 	if err != nil {
@@ -116,9 +157,9 @@ func edit(dry bool, filepaths []string) error {
 	originals := map[string]pttodo.Root{}
 	for _, target := range filepaths {
 		var original pttodo.Root
-		if b, err := ioutil.ReadFile(target); err != nil && !os.IsNotExist(err) {
+		if r, err := filePathReader(target); err != nil {
 			return err
-		} else if err := yaml.Unmarshal(b, &original); err != nil {
+		} else if err := yaml.NewDecoder(r).Decode(&original); err != nil {
 			return err
 		} else if c, err := yaml.Marshal(original.Todo); err != nil {
 			return err
@@ -134,9 +175,9 @@ func edit(dry bool, filepaths []string) error {
 		for {
 			err := func() error {
 				var todos []pttodo.Todo
-				if b, err := ioutil.ReadFile(path.Join(tempDir, path.Base(target))); err != nil {
+				if r, err := filePathReader(path.Join(tempDir, path.Base(target))); err != nil {
 					return err
-				} else if err := yaml.Unmarshal(b, &todos); err != nil {
+				} else if err := yaml.NewDecoder(r).Decode(&todos); err != nil {
 					return err
 				}
 				return nil
@@ -158,12 +199,12 @@ func edit(dry bool, filepaths []string) error {
 		return nil
 	}
 	for _, target := range filepaths {
-		b, err := ioutil.ReadFile(path.Join(tempDir, path.Base(target)))
+		r, err := filePathReader(path.Join(tempDir, path.Base(target)))
 		if err != nil {
 			return err
 		}
 		var newTodos []pttodo.Todo
-		if err := yaml.Unmarshal(b, &newTodos); err != nil {
+		if err := yaml.NewDecoder(r).Decode(&newTodos); err != nil {
 			return err
 		}
 		original := originals[target]
@@ -172,14 +213,20 @@ func edit(dry bool, filepaths []string) error {
 		for i := range newTodos {
 			newTodoIDs[newTodos[i].ID()] = struct{}{}
 		}
+
 		for i := range original.Todo {
 			if _, ok := newTodoIDs[original.Todo[i].ID()]; !ok {
+				original.Todo[i].TS = pttodo.TS(time.Now().Unix())
+				if string(original.Todo[i].Schedule) != "" && !original.Todo[i].Triggered() {
+					original.Scheduled = append(original.Scheduled, original.Todo[i])
+				}
 				original.Done = append(original.Done, original.Todo[i])
 			}
 		}
 		original.Todo = newTodos
 
 		original.AutoMove()
+
 		c, err := yaml.Marshal(original)
 		if err != nil {
 			return err
@@ -254,13 +301,13 @@ func _edit(dry bool, filepaths []string) error {
 	saveOne := func(filepath string) error {
 		tempFile := path.Join(tempDir, path.Base(filepath))
 		var rootTemp, rootOld pttodo.Root
-		if a, err := ioutil.ReadFile(tempFile); err != nil {
+		if a, err := filePathReader(tempFile); err != nil {
 			return err
-		} else if err := yaml.Unmarshal(a, &rootTemp); err != nil {
+		} else if err := yaml.NewDecoder(a).Decode(&rootTemp); err != nil {
 			return err
-		} else if b, err := ioutil.ReadFile(filepath); err != nil {
+		} else if b, err := filePathReader(filepath); err != nil {
 			return err
-		} else if err := yaml.Unmarshal(b, &rootOld); err != nil {
+		} else if err := yaml.NewDecoder(b).Decode(&rootOld); err != nil {
 			return err
 		} else if rootTemp.Equals(rootOld) {
 			//log.Printf("no changes to %s", filepath)
@@ -486,17 +533,17 @@ func dump(dry bool, writer io.Writer, filepaths []string, tags []string, search,
 }
 
 func filePathReader(path string) (io.Reader, error) {
-	var reader io.Reader
 	if path == "-" {
-		reader = os.Stdin
-	} else {
-		b, err := ioutil.ReadFile(path)
-		if err != nil {
-			return nil, err
-		}
-		reader = bytes.NewReader(b)
+		return os.Stdin, nil
 	}
-	return reader, nil
+	b, err := ioutil.ReadFile(path)
+	if os.IsNotExist(err) {
+		return bytes.NewReader([]byte("{}")), nil
+	}
+	if err != nil {
+		return nil, err
+	}
+	return bytes.NewReader(b), nil
 }
 
 func listDir(dname string) ([]string, error) {

cmd/pttodo-cli/testdata/test.yaml

@@ -1,20 +1,10 @@
 todo:
+- hi20890
+- hi
 - b
-scheduled:
-- todo: abc
-  schedule: "2022-05-01"
-  ts: Wed Mar 23 08:03:45 MDT 2022
-- todo: def
-  schedule: "2022-05-01"
-  ts: Wed Mar 23 08:04:05 MDT 2022
-done:
-- todo: other
-  ts: Wed Mar 23 09:44:57 MDT 2022
-- todo: b
-  ts: Wed Mar 23 09:45:13 MDT 2022
-- todo: a
-  ts: Wed Mar 23 09:45:15 MDT 2022
-- todo: a
-  ts: Wed Mar 23 09:45:24 MDT 2022
-- todo: a
-  ts: Wed Mar 23 09:45:31 MDT 2022
+- todo: loop
+  schedule: 10s
+- todo: past
+  schedule: "2000-01-02"
+scheduled: []
+done: []

pttodo/root.go

@@ -27,13 +27,14 @@ func (root *Root) AutoMove() {
 
 func (root *Root) MoveTodoToScheduled() {
 	for i := len(root.Todo) - 1; i >= 0; i-- {
-		if root.Todo[i].Schedule != "" && !root.Todo[i].Triggered() {
-			root.Scheduled = append(root.Scheduled, root.Todo[i])
-			for j := i; j < len(root.Todo)-1; j++ {
-				root.Todo[j] = root.Todo[j+1]
-			}
-			root.Todo = root.Todo[:len(root.Todo)-1]
+		if !root.Todo[i].Schedule.isFixedFuture() {
+			continue
 		}
+		root.Scheduled = append(root.Scheduled, root.Todo[i])
+		for j := i; j < len(root.Todo)-1; j++ {
+			root.Todo[j] = root.Todo[j+1]
+		}
+		root.Todo = root.Todo[:len(root.Todo)-1]
 	}
 }
 

pttodo/schedule.go

@@ -25,6 +25,42 @@ func (schedule Schedule) Next(t time.Time) (time.Time, error) {
 	return scheduler.next(t)
 }
 
+func (schedule Schedule) isFixedFuture() bool {
+	if !schedule.isFixed() {
+		return false
+	}
+	return schedule.isFuture()
+}
+
+func (schedule Schedule) isFixed() bool {
+	if schedule.empty() {
+		return false
+	}
+	scheduler := schedulerFactory(string(schedule))
+	switch scheduler.(type) {
+	case scheduleEZDate, scheduleDue:
+	default:
+		return false
+	}
+	return true
+}
+
+func (schedule Schedule) isFuture() bool {
+	if schedule.empty() {
+		return false
+	}
+	scheduler := schedulerFactory(string(schedule))
+	t, err := scheduler.next(time.Now())
+	if err != nil {
+		return false
+	}
+	return time.Now().Before(t)
+}
+
+func (schedule Schedule) empty() bool {
+	return string(schedule) == ""
+}
+
 type scheduler interface {
 	next(time.Time) (time.Time, error)
 }

pttodo/schedule_test.go

@@ -130,3 +130,60 @@ func TestSchedulerFactory(t *testing.T) {
 		}
 	})
 }
+
+func TestScheduleIsFixedFuture(t *testing.T) {
+	cases := map[string]struct {
+		input string
+		want  bool
+	}{
+		"empty": {
+			input: "",
+			want:  false,
+		},
+		"cron": {
+			input: "* * * * *",
+			want:  false,
+		},
+		"duration": {
+			input: "1m",
+			want:  false,
+		},
+		"due past": {
+			input: "123",
+			want:  false,
+		},
+		"due future": {
+			input: "9648154541",
+			want:  true,
+		},
+		"ez date short past": {
+			input: "2000-01-02",
+			want:  false,
+		},
+		"ez date short future": {
+			input: "2100-01-02",
+			want:  true,
+		},
+		"ez date long past": {
+			input: "2000-01-02T01",
+			want:  false,
+		},
+		"ez date long future": {
+			input: "2100-01-02T02",
+			want:  true,
+		},
+	}
+
+	for name, d := range cases {
+		c := d
+		t.Run(name, func(t *testing.T) {
+			schedule := Schedule(c.input)
+			got := schedule.isFixedFuture()
+			if got != c.want {
+				gotFuture := schedule.isFuture()
+				gotFixed := schedule.isFixed()
+				t.Errorf("want %v, got %v = %v && %v", c.want, got, gotFuture, gotFixed)
+			}
+		})
+	}
+}