yuzu-android

Commit Graph

Author	SHA1	Message	Date
Weiyi Wang	8b98f60e3c	input/sdl: lock map mutex after SDL call Any SDL invocation can call the even callback on the same thread, which can call GetSDLJoystickBySDLID and eventually cause double lock on joystick_map_mutex. To avoid this, lock guard should be placed as closer as possible to the object accessing code, so that any SDL invocation is with the mutex unlocked	2019-03-02 19:09:58 +01:00
James Rowe	09ac66388c	Input: Remove global variables from SDL Input Changes the interface as well to remove any unique methods that frontends needed to call such as StartJoystickEventHandler by conditionally starting the polling thread only if the frontend hasn't started it already. Additionally, moves all global state into a single SDLState class in order to guarantee that the destructors are called in the proper order	2019-03-02 19:09:34 +01:00
James Rowe	c8554d218b	Input: Copy current SDL.h/cpp files to impl This should make reviewing much easier as you can then see what changed happened between the old file and the new one	2019-03-02 18:38:11 +01:00

Author

SHA1

Message

Date

Weiyi Wang

8b98f60e3c

input/sdl: lock map mutex after SDL call

Any SDL invocation can call the even callback on the same thread, which can call GetSDLJoystickBySDLID and eventually cause double lock on joystick_map_mutex. To avoid this, lock guard should be placed as closer as possible to the object accessing code, so that any SDL invocation is with the mutex unlocked

2019-03-02 19:09:58 +01:00

James Rowe

09ac66388c

Input: Remove global variables from SDL Input

Changes the interface as well to remove any unique methods that
frontends needed to call such as StartJoystickEventHandler by
conditionally starting the polling thread only if the frontend hasn't
started it already. Additionally, moves all global state into a single
SDLState class in order to guarantee that the destructors are called in
the proper order

2019-03-02 19:09:34 +01:00

James Rowe

c8554d218b

Input: Copy current SDL.h/cpp files to impl

This should make reviewing much easier as you can then see what changed
happened between the old file and the new one

2019-03-02 18:38:11 +01:00

3 Commits (8b98f60e3c4c8a11f9de382fbf694173855f3a7a)