From ec1f0e007a9a74a5e4276c3989e1d29a4c78ec8d Mon Sep 17 00:00:00 2001 From: Bel LaPointe <153096461+breel-render@users.noreply.github.com> Date: Sun, 27 Apr 2025 11:49:57 -0600 Subject: [PATCH] debatably better --- src/cmd/cron/main.go | 13 ++----------- src/cmd/cron/main_test.go | 6 +----- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/cmd/cron/main.go b/src/cmd/cron/main.go index 14a8cf3..7c3cf0c 100644 --- a/src/cmd/cron/main.go +++ b/src/cmd/cron/main.go @@ -26,12 +26,7 @@ func Main(ctx context.Context) error { } func One(ctx context.Context) error { - f, err := feeds.New(ctx) - if err != nil { - return err - } - - return f.ForEach(ctx, func(feed feeds.Feed) error { + return feeds.ForEach(ctx, func(feed feeds.Feed) error { if err := one(ctx, feed); err != nil { return fmt.Errorf("failed to cron %s (%+v): %w", feed.Entry.ID, feed.Version, err) } @@ -56,9 +51,5 @@ func one(ctx context.Context, feed feeds.Feed) error { return fmt.Errorf("should GET %s", feed.Version.URL) - f, err := feeds.New(ctx) - if err != nil { - return fmt.Errorf("failed new feeds to executed %s: %w", feed.Entry.ID, err) - } - return f.Executed(ctx, feed.Entry.ID, feed.Version.Created) + return feeds.Executed(ctx, feed.Entry.ID, feed.Version.Created) } diff --git a/src/cmd/cron/main_test.go b/src/cmd/cron/main_test.go index 6c995c0..3ae3a7d 100644 --- a/src/cmd/cron/main_test.go +++ b/src/cmd/cron/main_test.go @@ -38,12 +38,8 @@ func TestOne(t *testing.T) { ctx := db.Test(t, ctx) - f, err := feeds.New(ctx) - if err != nil { - t.Fatal(err) - } for i := 0; i < 2; i++ { - if _, err := f.Insert(ctx, fmt.Sprintf("%s?idx=%d", s.URL, i), "* * * * *"); err != nil { + if _, err := feeds.Insert(ctx, fmt.Sprintf("%s?idx=%d", s.URL, i), "* * * * *"); err != nil { t.Fatal(err) } }