From 9498335e222cb5d34c50ad1a8cc8d1968aebd24b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Roberto=20Bani=C4=87?= <roberto@banic.hr>
Date: Fri, 14 Apr 2023 00:28:44 +0200
Subject: [PATCH] Deduplicate get_movie_guids and get_episode_guids

---
 src/plex.py | 78 +++++++++++++++++++----------------------------------
 1 file changed, 27 insertions(+), 51 deletions(-)

diff --git a/src/plex.py b/src/plex.py
index ba4fb41..a978724 100644
--- a/src/plex.py
+++ b/src/plex.py
@@ -1,7 +1,10 @@
-import re, requests, traceback
+import re, requests, os, traceback
+from typing import Dict, Union
+
 from urllib3.poolmanager import PoolManager
 from math import floor
 
+from plexapi.video import Episode, Movie
 from plexapi.server import PlexServer
 from plexapi.myplex import MyPlexAccount
 
@@ -30,55 +33,28 @@ class HostNameIgnoringAdapter(requests.adapters.HTTPAdapter):
         )
 
 
-def get_movie_guids(video, completed=True):
-    logger(f"Plex: {video.title} {video.guids} {video.locations}", 3)
+def get_guids(item: Union[Movie, Episode], completed=True):
+    guids: Dict[str, str] = dict(
+        guid.id.split('://')
+        for guid
+        in item.guids
+        if guid.id is not None and len(guid.id.strip()) > 0
+    )
 
-    movie_guids = {}
-    try:
-        for guid in video.guids:
-            # Extract source and id from guid.id
-            m = re.match(r"(.*)://(.*)", guid.id)
-            guid_source, guid_id = m.group(1).lower(), m.group(2)
-            movie_guids[guid_source] = guid_id
-    except Exception:
-        logger(f"Plex: Failed to get guids for {video.title}, Using location only", 1)
-
-    movie_guids["title"] = video.title
-    movie_guids["locations"] = tuple([x.split("/")[-1] for x in video.locations])
-
-    movie_guids["status"] = {
-        "completed": completed,
-        "time": video.viewOffset,
-    }
-
-    return movie_guids
-
-
-def get_episode_guids(episode, show, completed=True):
-    episode_guids_temp = {}
-    try:
-        for guid in episode.guids:
-            # Extract after :// from guid.id
-            m = re.match(r"(.*)://(.*)", guid.id)
-            guid_source, guid_id = m.group(1).lower(), m.group(2)
-            episode_guids_temp[guid_source] = guid_id
-    except Exception:
+    if len(guids) == 0:
         logger(
-            f"Plex: Failed to get guids for {episode.title} in {show.title}, Using location only",
+            f"Plex: Failed to get any guids for {item.title}, Using location only",
             1,
         )
 
-    episode_guids_temp["title"] = episode.title
-    episode_guids_temp["locations"] = tuple(
-        [x.split("/")[-1] for x in episode.locations]
-    )
-
-    episode_guids_temp["status"] = {
-        "completed": completed,
-        "time": episode.viewOffset,
-    }
-
-    return episode_guids_temp
+    return {
+        'title': item.title,
+        'locations': tuple([location.split("/")[-1] for location in item.locations]),
+        'status': {
+            "completed": completed,
+            "time": item.viewOffset,
+        }
+    } | guids
 
 
 def get_user_library_watched_show(show):
@@ -108,15 +84,15 @@ def get_user_library_watched_show(show):
                 if episode.parentIndex not in episode_guids:
                     episode_guids[episode.parentIndex] = []
 
-                episode_guids[episode.parentIndex].append(
-                    get_episode_guids(episode, show, completed=True)
+                episode_guids[episode.parentTitle].append(
+                    get_guids(episode, completed=True)
                 )
             elif episode.viewOffset > 0:
                 if episode.parentIndex not in episode_guids:
                     episode_guids[episode.parentIndex] = []
 
-                episode_guids[episode.parentIndex].append(
-                    get_episode_guids(episode, show, completed=False)
+                episode_guids[episode.parentTitle].append(
+                    get_guids(episode, completed=False)
                 )
 
         return show_guids, episode_guids
@@ -145,7 +121,7 @@ def get_user_library_watched(user, user_plex, library):
             for video in library_videos.search(unwatched=False):
                 logger(f"Plex: Adding {video.title} to {user_name} watched list", 3)
 
-                movie_guids = get_movie_guids(video, completed=True)
+                movie_guids = get_guids(video, completed=True)
 
                 user_watched[user_name][library.title].append(movie_guids)
 
@@ -156,7 +132,7 @@ def get_user_library_watched(user, user_plex, library):
 
                 logger(f"Plex: Adding {video.title} to {user_name} watched list", 3)
 
-                movie_guids = get_movie_guids(video, completed=False)
+                movie_guids = get_guids(video, completed=False)
 
                 user_watched[user_name][library.title].append(movie_guids)